Walkthrough

Added seeding infrastructure to populate the database with sample disaster data via a new npm script, enhanced the disasters GraphQL query to respect filters when calculating totals and pagination, and introduced comprehensive tests validating filtering and pagination behavior.

Changes

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 Seeds are sown in the database ground,
Filtered queries spin round and round,
Tests now verify each sorted row,
Disasters counted—swift they grow!
A burrow of code, refined and sound! 🌱

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings

services/disaster.service.ts (1)

91-117: Duplicated filter-building logic with getAllDisasters.

The WHERE-clause construction (lines 92–111) is nearly identical to lines 46–69 in getAllDisasters. Consider extracting a shared helper, e.g.:

function buildFilterClause(filter: DisasterFilter, startIndex = 1) {
  const conditions: string[] = [];
  const values: unknown[] = [];
  let paramIndex = startIndex;
  if (filter.type) { conditions.push(`type = $${paramIndex++}`); values.push(filter.type); }
  if (filter.status) { conditions.push(`status = $${paramIndex++}`); values.push(filter.status); }
  if (filter.dateFrom) { conditions.push(`date >= $${paramIndex++}::timestamp`); values.push(filter.dateFrom); }
  if (filter.dateTo) { conditions.push(`date <= $${paramIndex++}::timestamp`); values.push(filter.dateTo); }
  const whereClause = conditions.length > 0 ? `WHERE ${conditions.join(' AND ')}` : '';
  return { whereClause, values, paramIndex };
}

This eliminates the duplication and ensures both functions stay in sync when new filter fields are added.

scripts/seed.ts (1)

157-182: Add a top-level catch to main() for network errors.

If the server is unreachable, fetch throws a TypeError and the process exits with an unhandled rejection and a cryptic message. A catch on main() would give a friendlier diagnostic:

Suggested fix

-main();
+main().catch((err) => {
+  console.error('Seed failed:', err.message ?? err);
+  process.exit(1);
+});

• X
• Mastodon
• Reddit
• LinkedIn

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.